Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts_project#extends should be a single label, not a list #2140

Closed
alexeagle opened this issue Aug 24, 2020 · 1 comment
Closed

ts_project#extends should be a single label, not a list #2140

alexeagle opened this issue Aug 24, 2020 · 1 comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
3.0

Comments

@alexeagle
Copy link
Collaborator

Now that you can use the ts_config rule to represent tsconfig.json#extends dependencies on other tsconfig.json files, the extends[] feature in ts_project is kinda wrong. You have to list the whole transitive array rather than just the one tsconfig file you directly reference. Also you can't tell locally from reading a tsconfig.json file what the correct value of extends should be
@alexeagle alexeagle added this to the 3.0 milestone Aug 24, 2020
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Aug 24, 2020
feat(typescript): deprecate ts_project#extends
5e56f21 
See bazel-contrib#2140
@alexeagle alexeagle mentioned this issue Aug 24, 2020
Closed
@evahowe evahowe added the cleanup Tech debt, resolving it improves our own velocity label Aug 25, 2020
@alexeagle
Copy link
Collaborator Author

Actually I think the right thing is for extends to become a single value instead of a list. If tsconfig is a dict, then you can't use the ts_config rule at the same time.

@alexeagle alexeagle changed the title Remove ts_project#extends ts_project#extends should be a single label, not a list Aug 27, 2020
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Nov 3, 2020
chore(typescript): remove deprecated extends[]
12edf80 
BREAKING CHANGES
ts_project extends attribute no longer accepts a list, it should be a single tsconfig.json file or a ts_config label

Fixes bazel-contrib#2140
@alexeagle alexeagle mentioned this issue Nov 3, 2020
Merged
alexeagle pushed a commit that referenced this issue Nov 5, 2020
@alexeagle
chore(typescript): remove deprecated extends[]
0fcd6e6 
BREAKING CHANGES
ts_project extends attribute no longer accepts a list, it should be a single tsconfig.json file or a ts_config label

Fixes #2140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@alexeagle @evahowe