Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esbuild args can not contain whitespace #2997

Closed
jbedard opened this issue Oct 4, 2021 · 0 comments
Closed

esbuild args can not contain whitespace #2997

jbedard opened this issue Oct 4, 2021 · 0 comments
Assignees
Labels

Comments

@jbedard
Copy link
Collaborator

jbedard commented Oct 4, 2021

🐞 bug report

The esbuild args can not contain whitespace due to the use of params_file. params_file is designed for params (not json) but the actual cause of this issue is the bug mentioned at https://github.com/bazelbuild/rules_nodejs/blob/4.3.0/internal/common/params_file.bzl#L34-L38

Affected Rule

esbuild

Is this a regression?

Yes. Worked in v3 before the esbuild rule API changed.

🔬 Minimal Reproduction

esbuild(
    name = "banner_newline",
    args = {
        "banner": {
            "js": "//header\n//comments",
        },
    },
    entry_point = "main.js",
)

🔥 Exception or Error

Error while reading esbuild flags param file SyntaxError: Unexpected token 
 in JSON at position 22
    at JSON.parse (<anonymous>)
    ....

🌍 Your Environment

Rules_nodejs version:

4.3

@jbedard jbedard self-assigned this Oct 4, 2021
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Oct 4, 2021
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Oct 10, 2021
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Oct 12, 2021
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant