We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The esbuild args can not contain whitespace due to the use of params_file. params_file is designed for params (not json) but the actual cause of this issue is the bug mentioned at https://github.com/bazelbuild/rules_nodejs/blob/4.3.0/internal/common/params_file.bzl#L34-L38
args
params_file
esbuild
Yes. Worked in v3 before the esbuild rule API changed.
esbuild( name = "banner_newline", args = { "banner": { "js": "//header\n//comments", }, }, entry_point = "main.js", )
Error while reading esbuild flags param file SyntaxError: Unexpected token in JSON at position 22 at JSON.parse (<anonymous>) ....
Rules_nodejs version:
4.3
The text was updated successfully, but these errors were encountered:
fix(esbuild): allow whitespace within args
7c7613b
Fixes bazel-contrib#2997
d9c6a6e
c0122df
c8a3c28
3446425
fix(esbuild): allow whitespace within args (#2998)
181b55d
Fixes #2997
jbedard
No branches or pull requests
🐞 bug report
The esbuild
args
can not contain whitespace due to the use of params_file.params_file
is designed for params (not json) but the actual cause of this issue is the bug mentioned at https://github.com/bazelbuild/rules_nodejs/blob/4.3.0/internal/common/params_file.bzl#L34-L38Affected Rule
esbuild
Is this a regression?
Yes. Worked in v3 before the esbuild rule API changed.
🔬 Minimal Reproduction
🔥 Exception or Error
🌍 Your Environment
Rules_nodejs version:
4.3
The text was updated successfully, but these errors were encountered: