Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: always link #1440

Merged
merged 1 commit into from
Jun 16, 2020
Merged

refactor: always link #1440

merged 1 commit into from
Jun 16, 2020

Commits on Jun 16, 2020

  1. refactor: always link

    We now run the linker always, regardless of the configuration of the patch_module_resolver option.
    
    This creates some new flags to the launcher.sh
    - `--bazel_patch_module_resolver`/`--nobazel_patch_module_resolver` turns on/off the monkey-patches for require(). Still defaults to true (behavior unchanged)
    - `--nobazel_node_patches` disables the patches that make symlinks stay inside the execroot. Undocumented escape valve
    - `--nobazel_run_linker` disables running the linker, since it is now on by default. Undocumented escape valve
    
    As a later step we'll change default for patch_module_resolver to false (could be for 2.0 or 3.0 depending on how breaking it looks)
    alexeagle authored and Alex Eagle committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2e6bc72 View commit details
    Browse the repository at this point in the history