-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): upgrade rules_docker to 0.13.0 #1496
Conversation
482a370
to
df6ab08
Compare
Getting this one in CircleCI
It looks like
|
I don't know whether it's correct for rules_docker to look for |
a166187
to
2f5e082
Compare
77b89b5
to
d56d624
Compare
So if I try work around it by defining HOME just for that command I get this failure Is there some other way we could work around this for now? |
3af541b
to
d6828b3
Compare
not really sure how to proceed with this one, is there somewhere we could just define |
d6828b3
to
eeb7fe9
Compare
I tried a couple of things, looks like just having the integration test runner define a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup 🌯
b6fb970
to
84c83e1
Compare
Currently stuck because the environment for a bazel-in-bazel is missing something that git needs to do operations... |
I confirmed that it passes with |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
eb9be6e
to
793e0d7
Compare
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
793e0d7
to
406cdb8
Compare
406cdb8
to
30ed0ab
Compare
Also drop the patches we needed for older versions
30ed0ab
to
15a4fc3
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information