refactor(builtin): cleanup and optimizations in nodejs_binary & linker #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
linker_fixes
branch
from
c03908e
to
d26f191
Compare
gregmagolan
force-pushed
the
linker_fixes
branch
from
d26f191
to
f0d9e54
Compare
alexeagle
approved these changes
Apr 7, 2020
| @@ -179,7 +179,6 @@ def _nodejs_binary_impl(ctx): | |||
| _write_loader_script(ctx) | |||
|
|
|||
| env_vars = "export BAZEL_TARGET=%s\n" % ctx.label | |||
| env_vars += "export BAZEL_WORKSPACE=%s\n" % ctx.workspace_name | |||
There was a problem hiding this comment.
hmm, we didn't expect this anywhere else? looks like a breaking change to remove?
There was a problem hiding this comment.
its undocumented & internal use only, so I wouldn't consider it a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information