chore: remove ts_setup_workspace #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a no-op since 1.0 when we vendored requirejs for ts_devserver in https://github.com/bazelbuild/rules_nodejs/pull/1159/files#diff-fe375cd73fb89504b9b9a9a751518849 We should never add WORKSPACE dependencies so I don't see a value in users carrying this weight. BREAKING CHANGE: ts_setup_workspace was a no-op and has been removed. Simply remove it from your WORKSPACE file. Fixes #2033
alexeagle
requested review from
alan-agius4,
gregmagolan,
mattem and
soldair
as code owners
mattem
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a no-op since 1.0 when we vendored requirejs for ts_devserver in
https://github.com/bazelbuild/rules_nodejs/pull/1159/files#diff-fe375cd73fb89504b9b9a9a751518849
We should never add WORKSPACE dependencies so I don't see a value in users carrying this weight.
BREAKING CHANGE: ts_setup_workspace was a no-op and has been removed. Simply remove it from your WORKSPACE file.
Fixes #2033