Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow running NPM tools from execroot #2297

Merged
merged 1 commit into from
Dec 18, 2020

Commits on Nov 20, 2020

  1. feat: allow running NPM tools from execroot

    NPM tools are currently run out of external/{md}/node_modules. If the
    tool loads user-provided files in the execroot, which is the common
    case, then this can lead to bad interactions.
    
    Two examples of bad interactions are:
      1. A tool that loads React and the user code too,
         hooks becoming unusable.
      2. A tool that calls into a bundler like Webpack,
         potentially bundling duplicate packages.
    
    Signed-off-by: Duarte Nunes <duarte@hey.com>
    duarten committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    9acb606 View commit details
    Browse the repository at this point in the history