Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builtin): add DeclarationInfo sources from dependencies as inputs… #2353

Merged
merged 1 commit into from
Dec 16, 2020
Merged

fix(builtin): add DeclarationInfo sources from dependencies as inputs… #2353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/node/npm_package_bin.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"A generic rule to run a tool that appears in node_modules/.bin"

load("//:providers.bzl", "JSModuleInfo", "NpmPackageInfo", "node_modules_aspect", "run_node")
load("//:providers.bzl", "DeclarationInfo", "JSModuleInfo", "NpmPackageInfo", "node_modules_aspect", "run_node")
load("//internal/common:expand_variables.bzl", "expand_variables")
load("//internal/linker:link_node_modules.bzl", "module_mappings_aspect")

Expand Down Expand Up @@ -39,6 +39,8 @@ def _inputs(ctx):
inputs_depsets.append(d[NpmPackageInfo].sources)
if JSModuleInfo in d:
inputs_depsets.append(d[JSModuleInfo].sources)
if DeclarationInfo in d:
inputs_depsets.append(d[DeclarationInfo].declarations)
return depset(ctx.files.data, transitive = inputs_depsets).to_list()

def _impl(ctx):
Expand Down