-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tsconfig validator fails on chained tsconfig references #2512
Conversation
ts_project
/ ts_config
Thanks for the help, do you think you'll be able to get the tests green? |
Fixed most of the failing tests. There's a few that are still failing (on Windows only).
|
Friendly ping -- would it be possible to re-run the Windows tests to see whether the failures are specific to this PR? |
Hey sorry for the delay, juggling lots of things lately. You can always come ping me on slack if we're mostly done with a PR and a bit of attention is needed. Yes those windows failures are legit. Actually they are failures in non-sandboxed mode, which you could reproduce on any platform, it's just that Windows is always in that mode. What's happening is the typescript compiler does it's implicit look-around-the-disk to find ambient typings it can add to the program. When it does this, it finds typings we don't want to be included, they introduce conflicts with other typings. This is why we have |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@alexeagle Thanks for finishing this off! |
Fixes an issue (#2513) that the validator was always treating
extends
as a plain old file instead of readingTsConfigInfo
to get transitive deps. See the added test case, which shows a realistic example that would fail to validate due to missingtsconfig.base.json
(referenced bytsconfig.node.json
, which itself is referenced bymain/tsconfig.json
)(Note: one workaround in case anyone stumbles upon this PR is to use
validate = False
).