fix(protractor): unable to specify server as configurable attribute
#2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is not possible to specify the `protractor_web_test` server using a configurable attribute. i.e. using `select`. This happens because the `server` attribute is accessed directly in the macro so that Bazel is unable to respect the `select`. We fix this by no longer accessing the server in the macro.
devversion
force-pushed
the
fix/protractor-pkg-allow-config
branch
from
223c704
to
476f8c8
Compare
devversion
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
reviewed
Apr 29, 2021
| # If a server has been specified, add it to the runfiles together with it's required runfiles. This is necessary | ||
| # as the test executable references the server executable as per `TMPL_server` and executes it. | ||
| if ctx.executable.server: | ||
| server_files = depset( |
There was a problem hiding this comment.
nit : I would have named it server_runfiles but not important enough to fix
There was a problem hiding this comment.
yup. very true. I will send a follow-up!
alexeagle
approved these changes
Apr 29, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
…bazel-contrib#2643) Currently it is not possible to specify the `protractor_web_test` server using a configurable attribute. i.e. using `select`. This happens because the `server` attribute is accessed directly in the macro so that Bazel is unable to respect the `select`. We fix this by no longer accessing the server in the macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to specify the
protractor_web_testserver using a configurable attribute. i.e. using
select.This happens because the
serverattribute is accessed directlyin the macro so that Bazel is unable to respect the
select. Wefix this by no longer accessing the server in the macro.