Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-react-app on M1: force NodeJS version 16 #3102

Closed
wants to merge 1 commit into from
Closed

Fix create-react-app on M1: force NodeJS version 16 #3102

wants to merge 1 commit into from

Conversation

z-k-r
Copy link

@z-k-r z-k-r commented Nov 27, 2021

Fixes #3101

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3101

What is the new behavior?

Example launches

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Proposed fix inspired by @PengKuang in discussion for #2733

@google-cla google-cla bot added the cla: no label Nov 27, 2021
alexeagle
alexeagle reviewed Dec 2, 2021
View reviewed changes
examples/create-react-app/WORKSPACE
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")

# M1 Macs require Node 16+
node_repositories(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is present in all examples and applications using rules_nodejs, so let's not just fix it in one place.
I think #3107 is more principled

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@z-k-r z-k-r closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle left review comments

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

examples/create-react-app is broken on Apple M1
2 participants
@z-k-r @alexeagle