fix(typescript): ts_project transpiler produces js_library #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
ts_transpiler
branch
2 times, most recently
from
78d76a4
to
3bbfe21
Compare
alexeagle
commented
Jan 6, 2022
internal/js_library/js_library.bzl
Outdated
| runfiles = ctx.runfiles( | ||
| files = all_files, | ||
| transitive_files = depset( | ||
| transitive = files_depsets + typings_depsets, | ||
| transitive = files_depsets, |
There was a problem hiding this comment.
Reverted in #3189 for reference
gregmagolan
reviewed
Jan 6, 2022
alexeagle
force-pushed
the
ts_transpiler
branch
2 times, most recently
from
2a2d0f7
to
3cf389b
Compare
gregmagolan
reviewed
Jan 6, 2022
gregmagolan
reviewed
Jan 6, 2022
gregmagolan
reviewed
Jan 6, 2022
| ts_project( | ||
| name = "transpile_with_typeerror", | ||
| srcs = ["typeerror.ts"], | ||
| # The transpile_with_typeerror.check target will have a build failure |
There was a problem hiding this comment.
How does the build failure get ignored on CI with this one?
There was a problem hiding this comment.
the manual tag gets propagated to the build targets, so we don't run them. The test explicitly asks for the js_library which passes because typecheck action doesn't run
There was a problem hiding this comment.
🤦 I was starring right at it and didn't see the "manual" tag
This is needed so the .js files produced by the alternate transpiler are passed down the dependency graph.
alexeagle
force-pushed
the
ts_transpiler
branch
from
3cf389b
to
0f308ac
Compare
alexeagle
added a commit
that referenced
this pull request
Jan 7, 2022
alexeagle
added a commit
that referenced
this pull request
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so the .js files produced by the alternate transpiler
are passed down the dependency graph.