-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builtin): add basic ESM support #3294
Conversation
db47d48
to
03ca3d1
Compare
7001abf
to
5c7d4d2
Compare
Things to note:
|
fab02f1
to
8364d3c
Compare
I've extracted ts_project support into a seperate MR #3298 |
4aac85b
to
adb1158
Compare
CI looks mostly green now
|
adb1158
to
9ee1c0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me.
@@ -1,2 +1,3 @@ | |||
tag-version-prefix="" | |||
message="chore(release): %s" | |||
registry=https://registry.npmjs.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this change isn't related to this PR, but I needed it so that yarn wouldn't try pull packages from another registry that I have configured.
I don't think anyone else would have this issue, but it wouldn't cause an issue leaving it in as well.
Happy to remove if you think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem with me, just asked since it seemed unrelated 😄
PR Checklist
PR Type
What is the current behavior?
Issue Number: #3277
What is the new behavior?
Adds ESM support in for
nodejs_binary
,jasmine_node_test
andts_project
Does this PR introduce a breaking change?