Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): default STDOUT_CAPTURE_IS_NOT_AN_OUTPUT to falsey #3364

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Mar 11, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

line 358: STDOUT_CAPTURE_IS_NOT_AN_OUTPUT: unbound variable

Issue Number: N/A

What is the new behavior?

Silence

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I couldn't figure out a way to construct a test for this. I tried a syntax error in a JS file as well a using fail.spec.js. Neither of them gave the behavior my user was seeing inside our company. But once I applied this patch, their error message went away.

@alexeagle alexeagle merged commit 11952b1 into bazel-contrib:stable Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants