Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore back-compat file internal/node.bzl and mark as deprecated #545

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ npm_package(
"//third_party/github.com/gjtorikian/isBinaryFile:package_contents",
"//third_party/github.com/source-map:package_contents",
"//third_party/github.com/source-map-support:package_contents",
"//internal:package_contents",
"//internal/common:package_contents",
"//internal/history-server:package_contents",
"//internal/http-server:package_contents",
Expand Down
22 changes: 21 additions & 1 deletion internal/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1 +1,21 @@
# Marker file that this directory is a bazel package
# Copyright 2017 The Bazel Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

package(default_visibility = ["//visibility:public"])

filegroup(
name = "package_contents",
srcs = glob(["*"]),
visibility = ["//:__pkg__"],
)
2 changes: 2 additions & 0 deletions internal/collect_es6_sources.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
"""Private API surfaced for https://github.com/angular/angular backward-compatability

Users should not load files under "/internal"

NOTE: This file is DEPRECATED and will be removed in a future release.
"""

load("//internal/common:collect_es6_sources.bzl", _collect_es6_sources = "collect_es6_sources")
Expand Down
31 changes: 31 additions & 0 deletions internal/node.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Copyright 2017 The Bazel Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Private API surfaced for https://github.com/bazelbuild/rules_typescript backward-compatability

Users should not load files under "/internal"

NOTE: This file is DEPRECATED and will be removed in a future release.
"""

load(
"//internal/common:expand_into_runfiles.bzl",
_expand_location_into_runfiles = "expand_location_into_runfiles",
_expand_path_into_runfiles = "expand_path_into_runfiles",
)
load("//internal/common:sources_aspect.bzl", _sources_aspect = "sources_aspect")

sources_aspect = _sources_aspect
expand_location_into_runfiles = _expand_location_into_runfiles
expand_path_into_runfiles = _expand_path_into_runfiles