Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor /internal/test:node_modules into @npm + fixes #575

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Refactor /internal/test:node_modules into @npm + fixes #575

merged 2 commits into from
Feb 24, 2019

Commits on Feb 24, 2019

  1. Refactor /internal/test:node_modules into @npm + fixes 

    * `yarn_install/npm_install` `generate_build_file.js` now treats every folder under node_modules as a package regardless of it having a package.json file or not. npm will treat them as such when resolving so we should too.
* jasmine_runner attempts to require jasmine-core from `jasmine/node_modules/jasmine-core` before falling back to `jasmine-core`. this is so that if `jasmine-core`, which is a transitive dep of `jasmine` is not hoisted it can still be required with only the `@npm//jasmine` dep
* jasmine_node_test (in `@bazel/jasmine`) `jasmine` attribute change to `@npm//@bazel/jasmine` since this is the only guaranteed label. `@npm//jasmine` may not exists if it is not hoisted
* symlinked data files in yarn_install & npm_install cause issues if these are used as npm packages via `file://` on linux. copies are made of files instead
    @gregmagolan
    gregmagolan committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    767ec82 View commit details
    Browse the repository at this point in the history

  2. Address review comment

    @gregmagolan
    gregmagolan committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    f493dd6 View commit details
    Browse the repository at this point in the history