Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable our one py_test #842

Merged
merged 1 commit into from
Jun 11, 2019
Merged

test: disable our one py_test #842

merged 1 commit into from
Jun 11, 2019

Conversation

alexeagle
Copy link
Collaborator

This should unblock Bazel 0.27 RC which requires a python toolchain

See #809

gregmagolan
gregmagolan approved these changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@gregmagolan gregmagolan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The flag is not valid for 0.26. Will need to update to 0.27rc to set it.

@alexeagle
Copy link
Collaborator Author

The flag is in bazel but you can't set it with the common pseudo-command unless it's valid for every other command. Let's try with just build and test

@alexeagle alexeagle force-pushed the issue809 branch 3 times, most recently from bf04eea to 4d020d7 Compare June 11, 2019 15:52
@alexeagle
test: pin to python 2 for our one py_test
29a0d07 
This should unblock Bazel 0.27 RC which requires a python toolchain
@alexeagle alexeagle merged commit 8e080a6 into bazel-contrib:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@kyliau kyliau Awaiting requested review from kyliau

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @gregmagolan @googlebot