Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert oci_toolchain to crane_toolchain #25

Merged
merged 2 commits into from
Aug 9, 2022
Merged

refactor: convert oci_toolchain to crane_toolchain #25

merged 2 commits into from
Aug 9, 2022

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Aug 9, 2022

changes

  • rename oci_toolchain to crane_toolchain
  • split toolchain.bzl into dependencies.bzl and toolchain.bzl
  • fix mirror_releases.sh script and mirror releases from google/go-containerregistry instead of thesayyn/go-containeregistry
  • make toolchain_repos.bzl generic so that it can be reused for multiple toolchains.

@thesayyn thesayyn requested a review from f0rmiga August 9, 2022 19:37
@thesayyn
Copy link
Collaborator Author

thesayyn commented Aug 9, 2022

FYI: some tests are failing due to change from thesayyn/go-containeregistry to google/go-containerregistry

alexeagle
alexeagle approved these changes Aug 9, 2022
View reviewed changes
oci/private/versions.bzl Show resolved Hide resolved
@alexeagle
chore: expose LATEST_CRANE_VERSION
c9c9ced 
Makes it more consistent with our other rules
@alexeagle alexeagle merged commit ff8f25d into main Aug 9, 2022
@alexeagle alexeagle deleted the crane_toolchain branch August 9, 2022 21:51
alexeagle pushed a commit that referenced this pull request Mar 12, 2023
@meteorcloudy
Rename io_bazel_stardoc to stardoc (#25)
0daec85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @alexeagle