feat: implement oci_push #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
reviewed
Jan 3, 2023
|
|
||
| while (( $# > 0 )); do | ||
| case $1 in | ||
| (-t|--tag) |
There was a problem hiding this comment.
nit: ordering of the flag handling is reversed between tag and repository with -t|--tag and then --tags=* for tag and --repository=* and -r|--repository for repository
gregmagolan
reviewed
Jan 3, 2023
| repository = "ghcr.io/<OWNER>/image", | ||
| default_tags = ["6.4.1-rc1"] | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Should mention that you need to bazel run to push and that the tool accepts -r|--repository and -t|--tag flags so you can set the repository & tag at runtime. For tag this is particularly useful since when pushing semver versions users probably want the version to come from the latest tag on the repository and not be hard-coded in the BUILD file.
gregmagolan
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19