oci_tarball: set mtime to 2000-01-01 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can generate reproducible tars and avoid sha256sums changing for the tar output of the oci_tarball rule.
|
Potential fix for #328. |
thesayyn
approved these changes
Sep 29, 2023
|
this is possibly one of the many non-hermetic input here. |
thesayyn
changed the title
This was referenced Oct 2, 2023
|
was this PR tested on macs? macos (seems like bsd in general) tar does not have --mtime in its man page |
|
verified this does not work on macos, @thesayyn this PR should probably be reverted? |
|
Yup, reverting. |
|
@alexeagle , thanks for the revert. Yes, indeed I diid not test this on mac (I have none). |
reltuk
pushed a commit
to reltuk/rules_oci
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can generate reproducible tars and avoid sha256sums changing for the tar output of the oci_tarball rule.