feat: add nvcr.io to _WWW_AUTH #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu-k
commented
Feb 23, 2024
|
Could you add a test for this as well? |
|
i think you need to add the new repo to the tests folder. See: #471 (comment) |
|
Thank you, I was about to ask how it should be tested. |
|
The CI error is due to "no space left". Is this a temporary error, or do I have to find out a smaller image on nvcr.io? (I'm not sure if there's one because a lot of them are >1GB) |
thesayyn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reported the issue at #475 (comment) that
oci_pullfails to download images from nvcr.io. As suggested in the comment at #284 (comment), I added a new entry for nvcr.io to_WWW_AUTH. I locally applied the patch and confirmed thatoci_pullsuccessfully downloaded images which were previously failed.I took the values from the information provided at https://forums.developer.nvidia.com/t/how-to-get-manifest-from-nvcr-io-docker-registry-using-rest-api/72385/2