Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove registry references #551

Merged
merged 1 commit into from
May 2, 2024
Merged

refactor: remove registry references #551

merged 1 commit into from
May 2, 2024

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented May 2, 2024

Prefactor for #550

Changes:

  • Removes LATEST_ZOT_VERSION, LATEST_CRANE_VERSION from public api, no longer configurable.
  • Removes ZOT as a registry implementation, leaving only CRANE to keep 2.x branch green
  • Removes LAUNCHER_WRAPPER from tests to make it easier to drop the remaining registry toolchains
  • Removes some e2e tests for registry toolchains
  • Changes BCR presubmit to be run against e2e/smoke rather than e2e/crane_as_registry
  • Replaces non-hermetic xz call in genrule to be bsdtar instead.

@thesayyn thesayyn requested a review from alexeagle May 2, 2024 22:05
@thesayyn thesayyn changed the base branch from main to 2.x May 2, 2024 22:05
@thesayyn thesayyn force-pushed the remove_registry_references branch 2 times, most recently from 684624d to ce97ae4 Compare May 2, 2024 22:11
@thesayyn thesayyn force-pushed the remove_registry_references branch from ce97ae4 to 753806f Compare May 2, 2024 23:37
@thesayyn thesayyn merged commit 3f44965 into 2.x May 2, 2024
14 checks passed
@thesayyn thesayyn deleted the remove_registry_references branch May 2, 2024 23:49
thesayyn added a commit that referenced this pull request May 30, 2024
@thesayyn
refactor: remove registry references (#551)
75b8be6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @alexeagle