refactor: remove curl fallback #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
remote_curl_fallback
branch
from
eb665ef
to
d787152
Compare
alexeagle
reviewed
May 11, 2024
alexeagle
changed the title
Good suggestion, some of these are not exactly detectable but we can hint those. I'll see what can be done. |
thesayyn
force-pushed
the
remote_curl_fallback
branch
8 times, most recently
from
e62b977
to
d7d1112
Compare
Okay, it's done. |
|
@alexeagle PTAL again. |
thesayyn
force-pushed
the
remote_curl_fallback
branch
from
d7d1112
to
97f7b31
Compare
alexeagle
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #562
BREAKING CHANGE
Now that curl fallback is gone, users hitting that code path has to do following.
People hitting the curl fallback due to Schema 1 manifest will have to, either upgrade to
Bazel 7.1or use adigestinstead of atagfor oci_pull.People hitting the curl fallback due to oci-media-typed images being fetched without an
Acceptheader will have to, either upgrade toBazel 7.1, or use aCredential Helperto set headers expected by the registry, including the authorization headers.