Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable dockerfile example #605

Merged
merged 1 commit into from
May 31, 2024
Merged

chore: disable dockerfile example #605

merged 1 commit into from
May 31, 2024

Conversation

thesayyn
Copy link
Collaborator

This example required a bit of preconfiguration in CI settings, but the release pipeline uses a composite ruleset from bazel-contrib so we can't change it. Disabling the examples/dockerfile for now.

@thesayyn thesayyn requested a review from alexeagle May 31, 2024 17:59
@thesayyn thesayyn changed the base branch from main to 2.x May 31, 2024 17:59
alexeagle
alexeagle approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblocking to get a release out - I think this could just use a different job that's outside the bazel-contrib matrix though

@thesayyn thesayyn merged commit 32139d8 into 2.x May 31, 2024
@thesayyn thesayyn deleted the disable_dockerfile_example branch May 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @alexeagle