fix: return correct extension metadata #611
Conversation
| for platform in pull.platforms: | ||
| deps.append("_".join([pull.name] + platform.split("/"))) |
There was a problem hiding this comment.
Out of curiosity, what would be the reason to include these deps here? rules_oci v1.7 works without me including them via use_repo and I am curious, why I am suddenly asked to include them via the bazel mod tidy command.
There was a problem hiding this comment.
My understanding is it resolves an error like
WARNING: /builds/app/MODULE.bazel:38:20: The module extension oci defined in @rules_oci//oci:extensions.bzl reported incorrect imports of repositories via use_repo():
Not imported, but reported as direct dependencies by the extension (may cause the build to fail):
java_base_debug_nonroot_debian12, java_base_nonroot_debian12
Imported, but reported as indirect dependencies by the extension:
java_base_debug_nonroot_debian12_linux_amd64, java_base_debug_nonroot_debian12_linux_arm64_v8, java_base_nonroot_debian12_linux_amd64, java_base_nonroot_debian12_linux_arm64_v8
Fix the use_repo calls by running 'bazel mod tidy'.
There was a problem hiding this comment.
bazel mod tidy could support something like absolutely neccesary repos vs could have if build requires it kind of use_repo calls.
There was a problem hiding this comment.
but this what we have to do for now, if we want to avoid that annoying warning message. @fmeum probably has better ideas for this.
There was a problem hiding this comment.
I like @thesayyn's idea of something similar to a root_module_optional_deps attribute that silences the warning without also adding use_repo arguments. Could you file an issue for this if you think it would be useful?
fixes #529 #610