fix: add history entries for tars attribute #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This partially fixes #438 too. |
thesayyn
force-pushed
the
add_history_entries
branch
2 times, most recently
from
ad5d50d
to
e422780
Compare
alexeagle
reviewed
Jul 19, 2024
alexeagle
approved these changes
Jul 19, 2024
Signed-off-by: thesayyn <thesayyn@gmail.com>
thesayyn
force-pushed
the
add_history_entries
branch
from
e422780
to
ee081b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image-spec says that this field is optional, however some systems like seen in #645 require this field. Also, skipping history entries lead to broken images if the base image already had one.
fixes #645