Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in load.sh.tpl #657

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix typo in load.sh.tpl #657

merged 2 commits into from
Jul 25, 2024

Conversation

kopp
Copy link
Contributor

@kopp kopp commented Jul 22, 2024

Currently the generated template looks like

if [ -e "$LOADER}" ]; then
    CONTAINER_CLI="$LOADER"
elif command -v docker &> /dev/null; then
    CONTAINER_CLI="docker"
# ...

This will never evaluate the first if clause, because $LOADER} will for an empty LOADER expand to }.

@kopp
Copy link
Contributor Author

kopp commented Jul 22, 2024

@thesayyn could you please have a brief look at this super-mini PR? :)

@thesayyn
Copy link
Collaborator

Hmm, this seems to be failing. i guess we need to check if the loader is a file.

@thesayyn thesayyn merged commit 304b5cd into bazel-contrib:2.x Jul 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants