chore: add structure_test for custom registry example #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh i haven't seen this one before it put up a fix. already covered IN #79 |
thesayyn
approved these changes
Feb 25, 2023
alexeagle
pushed a commit
that referenced
this pull request
Mar 12, 2023
The file list of c-ares 1.15.0 is used for 1.16.1 since the following files are the same: 1. modules/c-ares/1.16.1/patches/add_build_file.patch 2. modules/c-ares/1.15.0/patches/add_build_file.patch And add_build_file.patch is adapted from https://github.com/grpc/grpc/tree/master/third_party/cares. I have tried to find c-ares version 1.16.1 in grpc project. A search of grpc project commit log shows that the most relevant thing is commit bdb3f860649bb4c136ba36bad3d9363fccbd29fa which mentions '-DgRPC_CARES_PROVIDER=package with c-ares 1.16.0 overrides'. My guess is that grpc has upgraded c-ares from 1.15.0 to 1.17.2 directly. I built c-ares 1.16.1 with `buildconf` on macOS. The resulted Makefile has the following two file list: 1. CSOURCES: C++ source files. 2. HHEADERS: C++ header files. A comparison of CSOURCES with cc_library srcs attribute shows that some source files are missing. ares_getopt.c is unneeded ares_getopt is not include in CSOURCES. It is included in SAMPLESOURCES. So this commit deletes it. This commit also adds the missing C++ source files. A comparison of HHEADERS with cc_library hdrs attribute shows that hdrs has three extra files: 1. ares_config.h 2. config-win32.h 3. ares_getopt.h ares_getopt.h will be deleted together with ares_getopt.c. Since I am not sure of the reason why the other two files exist, they are kept untouched. Fix #77 update update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.