Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gazelle Go dependency #60

Merged
merged 4 commits into from
May 2, 2023
Merged

Update Gazelle Go dependency #60

merged 4 commits into from
May 2, 2023

Conversation

mark-thm
Copy link
Contributor

@mark-thm mark-thm commented May 1, 2023

Closes #59.

Gazelle update includes changes to the repo name regex pattern and will enable use of target-determinator on Bazel 6/bzlmod/rules_python setups.

illicitonion
illicitonion approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll merge and release when CI finishes :)

@mark-thm
Copy link
Contributor Author

mark-thm commented May 1, 2023 •
edited
Loading

Thanks! I'm not quite sure I understand why CI is failing, any advice?

edit: looks like CI forces running ./scripts/update-dependencies, so have pushed a commit that does that

@illicitonion illicitonion merged commit 1341a10 into bazel-contrib:main May 2, 2023
@mark-thm mark-thm deleted the me/rules-py branch May 2, 2023 14:08
@illicitonion
Copy link
Collaborator

Released as https://github.com/bazel-contrib/target-determinator/releases/tag/v0.18.0 - thanks so much!

@mark-thm mark-thm mentioned this pull request May 3, 2023
Merged
illicitonion pushed a commit that referenced this pull request May 3, 2023
@mark-thm
Use third_party Gazelle dependency instead of workspace Gazelle depen…
4a95fe9 
…dency (#61)

#60 did not succeed in fixing #59 because source depended on the WORKSPACE-declared gazelle version instead of the go.mod declared gazelle version. In addition to moving the dependency to match go.mod, add test coverage for the defect described in #59 to ensure resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With Bazel 6 and bzlmod configured rules_python, target determinator complains of invalid characters
2 participants
@mark-thm @illicitonion