Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up --verbose #83

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

illicitonion
Copy link
Collaborator

We had changed how configurations are looked up for rule inputs in the main codepath but not the --verbose one. Now they share more code to avoid skew.

We had changed how configurations are looked up for rule inputs in the
main codepath but not the --verbose one. Now they share more code to
avoid skew.
pkg/hash_cache.go Show resolved Hide resolved
pkg/hash_cache.go Show resolved Hide resolved
Copy link
Collaborator

@sitaktif sitaktif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@illicitonion illicitonion merged commit eddc6f8 into bazel-contrib:main Feb 28, 2024
1 check passed
@illicitonion illicitonion deleted the fix-verbose branch February 28, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants