Fix protobuffers build by re-enabling allowJs
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of bazel-contrib#358, I removed the `allowJs` setting from the `tsconfig.json`. I didn't know why we needed `allowJs` and everything seemed to still work smoothly. However, when trying to build the extension from a completely fresh git checkout, I realized that the `protos.js` file was missing from the `out` directory. With `allowJs: false` the `src/protos/protos.js` file was no longer copied to the `out` directory. This only worked locally for me, because the current build is not hermetic.
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
cameron-martin
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #358, I removed the
allowJssetting from thetsconfig.json. I didn't know why we neededallowJsand everything seemed to still work smoothly.However, when trying to build the extension from a completely fresh git checkout, I realized that the
protos.jsfile was missing from theoutdirectory. WithallowJs: falsethesrc/protos/protos.jsfile was no longer copied to theoutdirectory. This only worked locally for me, because the current build is not hermetic.