Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add headers to headermap action inputs" #893

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

luispadron
Copy link
Collaborator

Reverts #888

@luispadron luispadron enabled auto-merge (squash) August 12, 2024 20:54
@luispadron luispadron merged commit fc57871 into master Aug 12, 2024
9 checks passed
@luispadron luispadron deleted the revert-888-luis/add-headermap-inputs branch August 12, 2024 21:24
@mattrobmattrob
Copy link
Collaborator

Why the revert of this one?

Copy link
Collaborator

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me. After discussing with @congt - we don't think the hmaptool code requires the headers themselves to generate the hmap, just the paths to those files, therefore we don't need to declare them as inputs.

We could potentially make this a bit more explicit by having the input to _make_hmap from _make_headermap_impl be an array of strings instead of an array of files, but that isn't entirely necessary. It would make things more consistent with what we're passing internally to the make_hmap method and what the method generally requires to invoke the hmap generator (and we rely on being able to pass strings in the case of VFS overlays). That would technically be a breaking change though, because make_hmap is exposed publicly.

@luispadron
Copy link
Collaborator Author

Right I was under the impression the hmap tool would need to access the headers themelves but effectively what it does is create a file that looks like:

Foo/MyHeader.h -> MyHeader.h

@luispadron
Copy link
Collaborator Author

This API should 100% be string_list instead of label_list: https://github.com/bazel-ios/rules_ios/pull/893/files#diff-c7a846a20e1dd3e0a809cc965ea0d4134555adb5bc82fcc298bfb6a933f5e3c0R110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants