Tweak visibility attributes/defaults. (#310)

(cherry picked from commit 979788e)

Co-authored-by: Thomas Van Lenten <thomasvl@google.com>

BUILD

@@ -23,6 +23,8 @@ filegroup(
     name = "for_bazel_tests",
     testonly = 1,
     srcs = [
+        "BUILD",
+        "LICENSE",
         "WORKSPACE",
         "//configs:for_bazel_tests",
         "//constraints:for_bazel_tests",

lib/BUILD

@@ -2,6 +2,10 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 licenses(["notice"])
 
+package(
+    default_visibility = ["//visibility:public"],
+)
+
 # This target is mainly for use by rules_apple and rules_swift.
 # When this target is linked into an XCTest binary, and the
 # `BUILD_WORKSPACE_DIRECTORY` environment variable is set, the relative paths of
@@ -19,15 +23,13 @@ objc_library(
         "@platforms//os:watchos": [],
         "//conditions:default": ["@platforms//:incompatible"],
     }),
-    visibility = ["//visibility:public"],
     alwayslink = True,
 )
 
 # Public bzl_library for anything that needs to depend on apple_support.bzl.
 bzl_library(
     name = "apple_support",
     srcs = ["apple_support.bzl"],
-    visibility = ["//visibility:public"],
     deps = [
         "@bazel_skylib//lib:types",
     ],
@@ -36,7 +38,6 @@ bzl_library(
 bzl_library(
     name = "lipo",
     srcs = ["lipo.bzl"],
-    visibility = ["//visibility:public"],
     deps = [
         ":apple_support",
         "@bazel_skylib//lib:shell",
@@ -46,21 +47,18 @@ bzl_library(
 bzl_library(
     name = "transitions",
     srcs = ["transitions.bzl"],
-    visibility = ["//visibility:public"],
 )
 
 # Public bzl_library for anything that needs to depend on xcode_support.bzl.
 bzl_library(
     name = "xcode_support",
     srcs = ["xcode_support.bzl"],
-    visibility = ["//visibility:public"],
 )
 
 # Public bzl_library for anything that needs to depend on repositories.bzl.
 bzl_library(
     name = "repositories",
     srcs = ["repositories.bzl"],
-    visibility = ["//visibility:public"],
 )
 
 # Consumed by bazel tests.

rules/BUILD

@@ -2,13 +2,16 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 licenses(["notice"])
 
+package(
+    default_visibility = ["//visibility:public"],
+)
+
 exports_files(["rules.doc.bzl"])
 
 # Public bzl_library for anything that needs to depend on apple_genrule.bzl.
 bzl_library(
     name = "apple_genrule",
     srcs = ["apple_genrule.bzl"],
-    visibility = ["//visibility:public"],
     deps = [
         "//rules/private:apple_genrule",
     ],
@@ -17,13 +20,11 @@ bzl_library(
 bzl_library(
     name = "toolchain_substitution",
     srcs = ["toolchain_substitution.bzl"],
-    visibility = ["//visibility:public"],
 )
 
 bzl_library(
     name = "universal_binary",
     srcs = ["universal_binary.bzl"],
-    visibility = ["//visibility:public"],
     deps = [
         "//lib:apple_support",
         "//lib:lipo",
@@ -35,7 +36,6 @@ bzl_library(
 bzl_library(
     name = "rules",
     srcs = ["rules.doc.bzl"],
-    visibility = ["//visibility:public"],
     deps = [
         ":toolchain_substitution",
         ":universal_binary",