Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling -dead_strip in opt builds #309

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Allow disabling -dead_strip in opt builds #309

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Mar 1, 2024

Fixes #308

@keith
Copy link
Member Author

keith commented Mar 1, 2024

i would prefer we make this a single feature, but im not sure that's possible?

@keith
Copy link
Member Author

keith commented Mar 1, 2024

this is kinda weird but i think this is still the right default for most folks, and the risk of getting it wrong is too high wrt huge binary sizes

@ewhauser ewhauser mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick will be requested when the pull request is marked ready for review BalestraPatrick is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones will be requested when the pull request is marked ready for review brentleyjones is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron will be requested when the pull request is marked ready for review luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob will be requested when the pull request is marked ready for review mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii will be requested when the pull request is marked ready for review thii is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a mechanism to disable -dead_strip in builds
1 participant
@keith