Add stubs for the Xcode rules in apple_support, for eventual migration from Bazel. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from Bazel. This change only stubs out rules; providers and flags will come later. The providers in particular need some more thought before locking down their names, since the current names (like `apple_common.XcodeVersionConfig`) don't meet Starlark provider naming conventions. PiperOrigin-RevId: 612472977 (cherry picked from commit 2177431)
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
keith
referenced
this pull request
Mar 4, 2024
…n from Bazel. This change only stubs out rules; providers and flags will come later. The providers in particular need some more thought before locking down their names, since the current names (like `apple_common.XcodeVersionConfig`) don't meet Starlark provider naming conventions. PiperOrigin-RevId: 612472977
brentleyjones
approved these changes
Mar 4, 2024
luispadron
approved these changes
Mar 4, 2024
keith
deleted the
ks/add-stubs-for-the-xcode-rules-in-apple_support-for-eventual-migration-from-bazel
branch
|
relevant upstream change being worked on bazelbuild/bazel@26c6add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only stubs out rules; providers and flags will come later. The providers in particular need some more thought before locking down their names, since the current names (like
apple_common.XcodeVersionConfig) don't meet Starlark provider naming conventions.PiperOrigin-RevId: 612472977
(cherry picked from commit 2177431)