Skip to content

Commit

Permalink
Fix empty glob in boost.dynamic_bitset and .random (#3108)
Browse files Browse the repository at this point in the history
More boost fixes for empty globs. I am also adding
`--incompatible_disallow_empty_glob` to the presubmit jobs to catch this
in future versions.

Needs skip-url-stability-check

---------

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
  • Loading branch information
hofbi and wep21 authored Nov 5, 2024
1 parent 6cda6fe commit 2e8102c
Show file tree
Hide file tree
Showing 12 changed files with 169 additions and 2 deletions.
16 changes: 16 additions & 0 deletions modules/boost.dynamic_bitset/1.83.0.bcr.1/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module(
name = "boost.dynamic_bitset",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"],
compatibility_level = 108300,
)

bazel_dep(name = "boost.assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.container_hash", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.integer", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.move", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.static_assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.throw_exception", version = "1.83.0.bcr.1")
bazel_dep(name = "rules_cc", version = "0.0.13")
30 changes: 30 additions & 0 deletions modules/boost.dynamic_bitset/1.83.0.bcr.1/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
load("@rules_cc//cc:defs.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

cc_library(
name = "boost.dynamic_bitset",
hdrs = glob(
[
"include/**/*.hpp",
],
exclude = ["include/boost/dynamic_bitset/detail/**/*.hpp"],
),
features = [
"parse_headers",
],
includes = ["include"],
textual_hdrs = glob([
"include/boost/dynamic_bitset/detail/**/*.hpp",
]),
deps = [
"@boost.assert",
"@boost.config",
"@boost.container_hash",
"@boost.core",
"@boost.integer",
"@boost.move",
"@boost.static_assert",
"@boost.throw_exception",
],
)
20 changes: 20 additions & 0 deletions modules/boost.dynamic_bitset/1.83.0.bcr.1/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
matrix:
platform:
- debian10
- debian11
- macos
- macos_arm64
- ubuntu2004
- ubuntu2204
- ubuntu2404
- windows
bazel: [7.x, rolling]
tasks:
verify_targets:
name: Verify build targets
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- '--process_headers_in_dependencies'
build_targets:
- '@boost.dynamic_bitset//:boost.dynamic_bitset'
10 changes: 10 additions & 0 deletions modules/boost.dynamic_bitset/1.83.0.bcr.1/source.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"integrity": "sha256-WVdk7ci9FDJinetJ/4fnRSpuQ5MKL/+kJLJUPtzyrYA=",
"strip_prefix": "dynamic_bitset-boost-1.83.0",
"url": "https://github.com/boostorg/dynamic_bitset/archive/refs/tags/boost-1.83.0.tar.gz",
"patch_strip": 0,
"overlay": {
"MODULE.bazel": "sha256-IJOp0JFZuXraZ+03BJL2HHda599QGMi6nGkFPteBPas=",
"BUILD.bazel": "sha256-06+rh/4b6Ka02HI72BndrOAe1MW6wxfSN/H2JAOB8YQ="
}
}
3 changes: 2 additions & 1 deletion modules/boost.dynamic_bitset/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"github:boostorg/dynamic_bitset"
],
"versions": [
"1.83.0"
"1.83.0",
"1.83.0.bcr.1"
],
"yanked_versions": {}
}
21 changes: 21 additions & 0 deletions modules/boost.random/1.83.0.bcr.1/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
module(
name = "boost.random",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"],
compatibility_level = 108300,
)

bazel_dep(name = "boost.array", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.dynamic_bitset", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.integer", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.io", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.range", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.static_assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.system", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.throw_exception", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.type_traits", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.utility", version = "1.83.0.bcr.1")
bazel_dep(name = "rules_cc", version = "0.0.13")
36 changes: 36 additions & 0 deletions modules/boost.random/1.83.0.bcr.1/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
load("@rules_cc//cc:defs.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

cc_library(
name = "boost.random",
hdrs = glob(
[
"include/**/*.hpp",
"include/**/*.ipp",
],
exclude = ["include/boost/random/detail/mixmax_skip_N17.ipp"],
),
features = [
"parse_headers",
],
includes = ["include"],
textual_hdrs = [
"include/boost/random/detail/mixmax_skip_N17.ipp",
],
deps = [
"@boost.array",
"@boost.assert",
"@boost.config",
"@boost.core",
"@boost.dynamic_bitset",
"@boost.integer",
"@boost.io",
"@boost.range",
"@boost.static_assert",
"@boost.system",
"@boost.throw_exception",
"@boost.type_traits",
"@boost.utility",
],
)
1 change: 1 addition & 0 deletions modules/boost.random/1.83.0.bcr.1/overlay/MODULE.bazel
20 changes: 20 additions & 0 deletions modules/boost.random/1.83.0.bcr.1/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
matrix:
platform:
- debian10
- debian11
- macos
- macos_arm64
- ubuntu2004
- ubuntu2204
- ubuntu2404
- windows
bazel: [7.x, rolling]
tasks:
verify_targets:
name: Verify build targets
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- '--process_headers_in_dependencies'
build_targets:
- '@boost.random//:boost.random'
10 changes: 10 additions & 0 deletions modules/boost.random/1.83.0.bcr.1/source.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"integrity": "sha256-5qVfaZ7Uy/d5CaYd+MBJGxqt5GxSrnYMDC3zdhkZrV8=",
"strip_prefix": "random-boost-1.83.0",
"url": "https://github.com/boostorg/random/archive/refs/tags/boost-1.83.0.tar.gz",
"patch_strip": 0,
"overlay": {
"MODULE.bazel": "sha256-yr47qCDJWIqcoiVIuIrYxLMHvghWkbKG/w2uikayX6A=",
"BUILD.bazel": "sha256-aeDLQbawdiL7m8WCmTLeV9ktvmKuMZ/zLj7olrLwh4A="
}
}
3 changes: 2 additions & 1 deletion modules/boost.random/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"github:boostorg/random"
],
"versions": [
"1.83.0"
"1.83.0",
"1.83.0.bcr.1"
],
"yanked_versions": {}
}

0 comments on commit 2e8102c

Please sign in to comment.