Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_mypy@0.1.0 #2545

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Aug 5, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_mypy) have been updated in this PR. Please review the changes.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Aug 5, 2024
@Wyverald Wyverald enabled auto-merge (squash) August 5, 2024 18:49
@mark-thm
Copy link
Contributor

mark-thm commented Aug 5, 2024

@Wyverald I'm a little stumped on the CI error here -- this works for me locally on a mac and using GitHub runners, Python 3.12 is set using rules_python in the ruleset. Any suggestions?

@Wyverald
Copy link
Member

Wyverald commented Aug 5, 2024

I can repro this, but have no idea how to debug it.

Try doing exactly what BCR's presubmit is doing and see if it repros for you:

mkdir -p ~/bcr
cd ~/bcr
git clone https://github.com/bazelbuild/bazel-central-registry .
git fetch origin refs/pull/2545/head
git checkout FETCH_HEAD

mkdir -p ~/test
cd ~/test
echo "bazel_dep(name='rules_mypy', version='0.1.0')" > MODULE.bazel
echo "common --registry=file://$HOME/bcr/" > .bazelrc
bazel build @rules_mypy//...

mark-thm added a commit to theoremlp/rules_mypy that referenced this pull request Aug 5, 2024
@mark-thm
Copy link
Contributor

mark-thm commented Aug 5, 2024

It looks like I ran into bazelbuild/rules_python#1824. After pinning a specific py_binary version I was able to successfully build from a repo tgz the same way BCR does.

@mark-thm mark-thm deleted the theoremlp/rules_mypy@v0.1.0-680dac89 branch August 5, 2024 23:39
@mark-thm
Copy link
Contributor

mark-thm commented Aug 5, 2024

Feel free to close this one out.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum closed this Aug 6, 2024
auto-merge was automatically disabled August 6, 2024 06:30

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants