Skip to content

Commit

Permalink
Update: golang.org/x/exp & golang.org/x/oauth2 deps.
Browse files Browse the repository at this point in the history
Update:
  - golang.org/x/exp    v0.0.0-20190121172915-509febef88a4 -> v0.0.0-20230713183714-613f0c0eb8a1
  - golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be -> v0.10.0

These were very old dependencies and there is no way to override them to newer ones by Gazelle user.
1. You cannot execute go_repository before calling gazelle_dependencies as @bazel_gazelle_go_repository_cache is not yet ready.
2. If you execute go_repository AFTER calling gazelle_dependences, the previously loaded old verision by gazelle_dependencies
takes precendence.

It led to issues like:
  - #1468
  - https://stackoverflow.com/questions/64929217/bazel-gazelle-error-no-such-package-org-golang-x-tools-go-analysis-internal

Fixes: #1468
  • Loading branch information
sfc-gh-ptabor committed Jul 20, 2023
1 parent a0705b3 commit 71b22e7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,8 @@ def gazelle_dependencies(
go_repository,
name = "org_golang_x_exp",
importpath = "golang.org/x/exp",
sum = "h1:c2HOrn5iMezYjSlGPncknSEr/8x5LELb/ilJbXi9DEA=",
version = "v0.0.0-20190121172915-509febef88a4",
sum = "h1:MGwJjxBy0HJshjDNfLsYO8xppfqWlA5ZT9OhtUUhTNw=",
version = "v0.0.0-20230713183714-613f0c0eb8a1",
)
_maybe(
go_repository,
Expand All @@ -306,8 +306,8 @@ def gazelle_dependencies(
go_repository,
name = "org_golang_x_oauth2",
importpath = "golang.org/x/oauth2",
sum = "h1:vEDujvNQGv4jgYKudGeI/+DAX4Jffq6hpD55MmoEvKs=",
version = "v0.0.0-20180821212333-d2e6202438be",
sum = "h1:zHCpF2Khkwy4mMB4bv0U37YtJdTGW8jI0glAApi0Kh8=",
version = "v0.10.0",
)
_maybe(
go_repository,
Expand Down

0 comments on commit 71b22e7

Please sign in to comment.