Skip to content

Commit

Permalink
Remove unused, empty //rules:bins filegroup, allowing us to simplify …
Browse files Browse the repository at this point in the history
…distribution/BUILD (#359)

//rules:bins has not been used since 14f17ae

Alternative to #358
  • Loading branch information
tetromino authored Mar 10, 2022
1 parent 5bffd04 commit 898cd6d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 39 deletions.
7 changes: 0 additions & 7 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,3 @@ filegroup(
"//toolchains/unittest:distribution",
] + glob(["*.bzl"]),
)

filegroup(
name = "bins",
srcs = [
"//rules:bins",
],
)
26 changes: 2 additions & 24 deletions distribution/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,15 @@ package(
default_visibility = ["//visibility:private"],
)

pkg_tar(
name = "srcs",
srcs = ["//:distribution"],
mode = "0444",
# Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0",
package_dir = "",
strip_prefix = ".",
)

pkg_tar(
name = "bins",
srcs = ["//:bins"],
mode = "0555",
# Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0",
package_dir = "",
strip_prefix = ".",
)

# Build the artifact to put on the github release page.
pkg_tar(
name = "bazel-skylib-%s" % version,
srcs = ["//:distribution"],
extension = "tar.gz",
mode = "0644",
# Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0",
strip_prefix = ".",
deps = [
":bins.tar",
":srcs.tar",
],
)

print_rel_notes(
Expand Down
8 changes: 0 additions & 8 deletions rules/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@ filegroup(
],
)

filegroup(
name = "bins",
srcs = glob(["*.sh"]),
visibility = [
"//:__pkg__",
],
)

# export bzl files for the documentation
exports_files(
glob(["*.bzl"]),
Expand Down

0 comments on commit 898cd6d

Please sign in to comment.