Add expand_template rule #330
Conversation
|
@brandjon @tetromino Can you review it again, please? I need |
|
Hey @Vertexwahn if you can't get a response here, we'd love to have your contribution in https://github.com/aspect-build/bazel-lib instead! |
|
@alexeagle If this gets not merged I will open up a PR on bazel-lib the next days. |
|
@tetromino Sorry to ping you again - but you reviewed the PR already in the past, I applied several changes (added tests, etc). Can you please review again? |
There was a problem hiding this comment.
My apologies for the delayed review!
Tests look good; what remains is docs.
Please add a bzl_library entry for expand_template to rules/BUILD.
Please add a stardoc_with_diff_test target in docs/BUILD which uses that bzl_library.
Then use bazel run //docs:update to create the expand_template_doc.md file, and add a link to the doc in README.md
Add a basic expand_template rule to support trivial search and replace use cases.
|
@tetromino I addressed all your comments. Looking forward to a merge ;) |
Followup to bazelbuild#330: remove the wrapper macro and export the rule directly; the macro does not serve any useful function. As a side effect, this fixes the inability to set tags etc., since the macro did not support **kwargs.
Followup to #330: remove the wrapper macro and export the rule directly; the macro does not serve any useful function. As a side effect, this fixes the inability to set tags etc., since the macro did not support **kwargs.
Resolves: #191
An example of how this can be usefull can be found here: https://github.com/catchorg/Catch2/pull/2387/files
Could be also helpfull here: https://github.com/AcademySoftwareFoundation/openexr/blob/8587f4eed1d396a9c545d59e7b231d9d4b2cd8ef/BUILD.bazel#L21