-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy_directory rule #366
Conversation
d8287d6
to
e8214e3
Compare
@tetromino do you have any feedback on this PR? |
@kormide,please ask one of the other maintainers for review - I will have very limited availability until July (paternity leave). |
Yes, no problem. And congratulations! 🎉 |
@brandjon Do you have any feedback on this PR? |
@hvadehra can you review this one? |
70f2941
to
6a0e146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Are we ready to merge, or does this require further review? |
Maybe we can add another The difference between The difference between filegroup(
name = "files_to_copy",
srcs = glob(["a/*.h", "b/*.h"]),
)
copy_files_to_directory(
name = "copy_files",
srcs = [":files_to_copy"],
output = "path/to/target/directory",
) I found a related |
@kkpattern Something like this copy_to_directory rule that we wrote? |
Yes! Looks like exactly what we need. |
Following up on the discussion in @alexeagle's PR (#323) to add a new
copy_directory
rule.