Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bzl_library to depend on non-bzl_library targets #495

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Commits on Apr 23, 2024

  1. Allow bzl_library to depend on non-bzl_library targets

    Notably, `filegroup`. `bzl_library` doesn't actually read anything from the `StarlarkLibraryInfo` provider, and requiring all deps to be other `bzl_library` targets is really painful for anyone loading .bzls from `@bazel_tools` or `@platforms` because those core modules/repos don't want a dependency on Skylib just for access to `bzl_library`.
    
    The medium-term plan will be to move `bzl_library` into `@bazel_tools`; but before then, this can serve as a stop-gap.
    Wyverald committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    11fd29b View commit details
    Browse the repository at this point in the history
  2. buildifier

    Wyverald committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9a6d472 View commit details
    Browse the repository at this point in the history
  3. fix tests

    Wyverald committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d4cd8bf View commit details
    Browse the repository at this point in the history
  4. BUILDIFIER

    Wyverald committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ad07db2 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. better test setup

    Wyverald committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    63ad231 View commit details
    Browse the repository at this point in the history
  2. fix load order

    Wyverald committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5badc99 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    015248d View commit details
    Browse the repository at this point in the history