Skip to content

Commit

Permalink
Remove restriction on generate_pdb_file to be only used in dbg and fa…
Browse files Browse the repository at this point in the history
…stbuild mode

Users may want to build in opt mode and still want the pdb file to be a linking action output.
See bazelbuild/rules_cc#94 (comment)

RELNOTES: None
PiperOrigin-RevId: 372351216
  • Loading branch information
meteorcloudy authored and copybara-github committed May 6, 2021
1 parent 762b5d8 commit 6dc941e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tools/cpp/windows_cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,6 @@ def _impl(ctx):

generate_pdb_file_feature = feature(
name = "generate_pdb_file",
requires = [
feature_set(features = ["dbg"]),
feature_set(features = ["fastbuild"]),
],
)

output_execpath_flags_feature = feature(
Expand Down

0 comments on commit 6dc941e

Please sign in to comment.