Skip to content

Commit

Permalink
Explicitly add jdk.crypto.ec to the list of modules.
Browse files Browse the repository at this point in the history
JDK 11 adds support for TLSv1.3 but the handshake while downloading from
github fails while download external repositories.

RELNOTES: Explicitly set https.protocols and exclude TLSv1.3.

Partly address #6592.

Closes #7337.

PiperOrigin-RevId: 232191351
  • Loading branch information
meisterT authored and Copybara-Service committed Feb 3, 2019
1 parent 0068055 commit 9075514
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/minimize_jdk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ if [ "$1" == "--allmodules" ]; then
modules="ALL-MODULE-PATH"
else
modules=$(cat "$2" | paste -sd "," - | tr -d '\r')
# We have to add this module explicitly because jdeps doesn't find the
# dependency on it but it is still necessary for TLSv1.3.
modules="$modules,jdk.crypto.ec"
fi
fulljdk=$1
out=$3
Expand Down

0 comments on commit 9075514

Please sign in to comment.