Skip to content

Commit

Permalink
rm all mentions of juliexxia in the codebase
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 355953736
  • Loading branch information
Googler authored and copybara-github committed Feb 6, 2021
1 parent 0e8d94c commit fe8275d
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,10 @@ private static void validateFunctionOutputsMatchesDeclaredOutputs(
* Given a map of build settings to their values, return a map with the same build settings but
* in their canonicalized string form to their values.
*
* <p>TODO(juliexxia): It would be nice if this method also returned a map of the canonicalized
* settings to given settings so that when we throw the "unrecognized returned option" warning
* we can show the setting as the user gave it as well as in its canonicalized form.
* <p>TODO(blaze-configurability): It would be nice if this method also returned a map of the
* canonicalized settings to given settings so that when we throw the "unrecognized returned
* option" warning we can show the setting as the user gave it as well as in its canonicalized
* form.
*/
private static ImmutableMap<String, Object> canonicalizeTransitionOutputDict(
Map<String, Object> dict,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import net.starlark.java.eval.Starlark;

/** Starlark namespace for creating build settings. */
// TODO(juliexxia): Consider adding more types of build settings, specifically other label types.
public class StarlarkConfig implements StarlarkConfigApi {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ public ImmutableSet<String> requiresOptionFragments(BuildOptions buildOptions) {
}

/** Exception class for exceptions thrown during application of a starlark-defined transition */
// TODO(juliexxia): add more information to this exception e.g. originating target of transition
// TODO(blaze-configurability): add more information to this exception e.g. originating target of
// transition.
public static class TransitionException extends Exception {
private final String message;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
* already parsed all native options (including those needed for loading). This class is in charge
* of parsing and setting the starlark options for this {@link OptionsParser}.
*/
// TODO(juliexxia): confront the spectre of aliased build settings
public class StarlarkOptionsParser {

private final SkyframeExecutor skyframeExecutor;
Expand Down Expand Up @@ -127,7 +126,7 @@ public static StarlarkOptionsParser newStarlarkOptionsParser(
}

/** Parses all pre "--" residue for Starlark options. */
// TODO(juliexxia): This method somewhat reinvents the wheel of
// TODO(blaze-configurability): This method somewhat reinvents the wheel of
// OptionsParserImpl.identifyOptionAndPossibleArgument. Consider combining. This would probably
// require multiple rounds of parsing to fit starlark-defined options into native option format.
@VisibleForTesting
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,8 @@ public void testAllowlistOnRuleNotTargets() throws Exception {
.containsExactly("post-transition");
}

// TODO(juliexxia): flip this test when this isn't allowed anymore.
// TODO(blaze-configurability): We probably want to eventually turn this off. Flip this test when
// this isn't allowed anymore.
@Test
public void testAllowlistOnTargetsStillWorks() throws Exception {
// allowlists //test/...
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ protected final BuildConfigurationCollection createConfigurations(
optionsParser.parse(allArgs);
optionsParser.parse(args);

// TODO(juliexxia): when the starlark options parsing work goes in, add type verification here.
// TODO(blaze-configurability): It would be nice to be able to do some starlark options loading
// to ensure that the values given in this map are the right types for their keys.
optionsParser.setStarlarkOptions(starlarkOptions);

BuildOptions buildOptions = ruleClassProvider.createBuildOptions(optionsParser);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@
*
* <p>This tests core cquery behavior (behavior that doesn't depend on <code>--output</code>).
* Output format-specific behavior is covered in dedicated test classes.
*
* <p>TODO(juliexxia): separate out tests in this file into one test per tested functionality.
*/
@RunWith(JUnit4.class)
public class ConfiguredTargetQuerySemanticsTest extends ConfiguredTargetQueryTest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
/**
* Test for cquery's proto output format.
*
* <p>TODO(juliexxia): refactor all cquery output format tests to consolidate duplicate
* <p>TODO(blaze-configurability): refactor all cquery output format tests to consolidate duplicate
* infrastructure.
*/
public class ProtoOutputFormatterCallbackTest extends ConfiguredTargetQueryTest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ private List<String> getOutput(String queryExpression, CqueryOptions.Transitions
PostAnalysisQueryEnvironment<KeyedConfiguredTarget> env =
((ConfiguredTargetQueryHelper) helper).getPostAnalysisQueryEnvironment(targetPatternSet);
options.transitions = verbosity;
// TODO(juliexxia): Test late-bound attributes.
// TODO(blaze-configurability): Test late-bound attributes.
TransitionsOutputFormatterCallback callback =
new TransitionsOutputFormatterCallback(
reporter,
Expand Down

0 comments on commit fe8275d

Please sign in to comment.