Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear or impossible to return new includes from a custom rule #117

Closed
zrlk opened this issue Apr 13, 2015 · 3 comments
Closed

Unclear or impossible to return new includes from a custom rule #117

zrlk opened this issue Apr 13, 2015 · 3 comments

Comments

@zrlk
Copy link

zrlk commented Apr 13, 2015

(Running under a custom build of Bazel that grants genproto the same powers in C++ as it has in Java; see #114 ,) I'm not able to get a depending cc_library to respect the includes that are returned by a custom rule it depends upon. I've added "includes" to the custom rule's providers list.

@hanwen
Copy link
Contributor

hanwen commented Apr 15, 2015

As detailed in #114 , you should be generating C++ sources, and bulding a cc_library from that. Does that work for you?

@zrlk
Copy link
Author

zrlk commented Apr 15, 2015

I ended up writing a macro instead of a custom rule (see genproto_all in https://github.com/google/kythe/blob/master/tools/build_rules/genproto.bzl). With this approach I need to remember to depend on foo_proto_cc instead of foo_proto, but aside from that, things are working now.

@ulfjack
Copy link
Contributor

ulfjack commented Apr 17, 2015

Interoperability with native rules is a bigger topic than this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants