-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto_library build rules #52
Comments
We're not yet ready to open-source the more generic |
(sorry, shouldn't have closed this just yet) |
Is there a timeline for releasing proto_library support? We'd love to ditch Kythe's campfire build system, but can't feasibly do so without proto_library. |
For now we have a genproto that supports Java using Skylark (see On Fri, Apr 3, 2015 at 1:57 AM Collin Winter notifications@github.com
|
The Kythe team has found that the genproto rule isn't as easy to use as you've suggested. It seems to have at least one severe issue that we'd need fixed before we migrate to using Bazel. Bazel special-cases the genproto Skylark rule for Java (see BazelJavaRuleClasses.java). It does not, however, support the native C++ rules in the same way. We have thought of a few ways to workaround this problem but feel that they would burden us in the same way as having our own build system. Switching to Bazel (from Campfire) is meant to remove these types of concerns from our team. Likewise, having to write our own support for C++ (and Go) means maintaining even more build-related logic. It would be nice if C++ was supported in genproto by the Bazel team. That would minimize our need for forking/maintaining the existing rule. Other Relevant C++ issues: |
You should be able to write a genproto rule that generate .c or .cc files We're working on proto_library as well as go support this quarter. It's On Mon, Apr 13, 2015 at 7:06 PM, Cody Schroeder notifications@github.com
|
I have a simple macro that creates genrule and cc_library targets for proto files, just FYI: |
A quick status update: this is something we working on shiping but it will take a long time |
Any ETA on this? We're using protos in Shipshape and would love to use standard rules. |
Not yet. We are thinking of shipping it by the end of the year but it is On Tue, Oct 6, 2015, 1:53 AM clconway notifications@github.com wrote:
|
It should happens this quarter |
Will this support Go when it ships? |
Yes. It will support both Skylark and native rules. |
Hi! Is there any status update? Thanks |
I think we are moving to making the rules provided by google/protobuf good one instead of shipping our legacy support. No ETA. |
Any status update on this? |
What is the current guidance for generating Java from proto files? |
@robfig I just released https://github.com/pubref/rules_protobuf/tree/0.1.1 for my own use but hopefully it's useful for you. |
@pcj I love your graphical explanation of that repo :D |
It seems that proto_library now exists here: http://bazel.io/docs/be/protocol-buffer.html |
@smr277 It's probably still premature for native |
@smr277, proto_library doesn't generate for each language at this point. There will need to be per-language support for protobuf, and that is still in the works. |
Some form of status update is in |
@cgrushko you mentioned in an issue for grpc-java that there's a first class support for |
Oh, they're under java, and I was looking under protocol buffer. My bad. Please ignore me! Sorry for the noise. |
(didn't know it got undocumented; I thought that only happens at the next release) |
@cgrushko nice, thanks! |
Blog post: https://bazel.build/blog/index.html#protocol-buffers-in-bazel I'll close this issue because it seems to have grown to include too many things; if your issue hasn't been addressed, please open a new issue and CC me. |
For posterity, https://bazel.build/blog/2017/02/27/protocol-buffers.html is the permalink to the blog post. |
I failed to compile Bazel from head by Bazel. When will this feature be distributed? |
Next bazel release. There should be an issue open for it. |
The Build Encyclopedia documentation for
objc_proto_library
referencesproto_library
, which does not seem to have been open sourced yet.On the same note,
objc_proto_library
seems to be the only available rule for building proto libraries. What is the plan forproto_library
rules for other languages?The text was updated successfully, but these errors were encountered: