Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol Buffer support lacks configurability #11933

Closed
shs96c opened this issue Aug 12, 2020 · 3 comments
Closed

Protocol Buffer support lacks configurability #11933

shs96c opened this issue Aug 12, 2020 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Server Issues for serverside rules included with Bazel type: feature request

Comments

@shs96c
Copy link
Contributor

shs96c commented Aug 12, 2020

Description of the feature request:

protoc configuration in bazel assumes a single configuration is used throughout the build. While this may be true in a small repo, it's possible for there to be more than one class of usage within a repo, eg.when using ServiceTalk and regular protobufs.

Right now, there's a proto_lang_toolchain which allows a single configuration per language. This isn't sufficiently granular.

Feature requests: what underlying problem are you trying to solve with this feature?

I'd like to compile protobufs for java using more than one configuration of protoc

What's the output of bazel info release?

3.4.1

Have you found anything relevant by searching the web?

There are multiple rulesets out there that attempt to address this, such as pubref/rules_protobuf and stackb/rules_protobuf Neither of these is ideal, and it seems a pity that bazel's own baked in rules aren't sufficient.

@gregestren gregestren added team-Rules-Server Issues for serverside rules included with Bazel untriaged labels Aug 13, 2020
@c-mita c-mita added P2 We'll consider working on this in future. (Assignee optional) type: feature request and removed untriaged labels Aug 17, 2020
@Yannic
Copy link
Contributor

Yannic commented Aug 17, 2020

This will most-likely done as part of the protobuf-starlarkification (#10005).

@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 18, 2020
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 12, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Server Issues for serverside rules included with Bazel type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants