Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove native Protobuf rules #10005

Closed
8 of 9 tasks
Yannic opened this issue Oct 13, 2019 · 2 comments
Closed
8 of 9 tasks

Remove native Protobuf rules #10005

Yannic opened this issue Oct 13, 2019 · 2 comments
Assignees
@Yannic
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Server Issues for serverside rules included with Bazel type: feature request

Comments

@Yannic
Copy link
Contributor

Yannic commented Oct 13, 2019 •
edited
Loading

This is the ☔️-bug for removing the native versions of everything related to Protocol Buffers from Bazel.

Blocked on:
Yannic added a commit to Yannic/rules_proto_bazelbuild that referenced this issue Oct 13, 2019
@Yannic
Create proto_toolchain and expose values of command-line flags on it
919671e 
Working towards bazelbuild/bazel#10005
This was referenced Oct 13, 2019
Closed
Closed
@jin jin added team-Rules-Server Issues for serverside rules included with Bazel untriaged labels Oct 14, 2019
@jin
Copy link
Member

jin commented Oct 14, 2019

cc @lberki

@hlopko hlopko added P2 We'll consider working on this in future. (Assignee optional) type: feature request and removed untriaged labels Oct 28, 2019
Yannic added a commit to Yannic/rules_proto_bazelbuild that referenced this issue Dec 18, 2019
@Yannic
Create proto_toolchain and expose values of command-line flags on it
a9099b0 
Working towards bazelbuild/bazel#10005
Yannic added a commit to Yannic/rules_proto_bazelbuild that referenced this issue Dec 18, 2019
@Yannic
Create proto_toolchain and expose values of command-line flags on it
fe54705 
Working towards bazelbuild/bazel#10005
Yannic added a commit to Yannic/rules_proto_bazelbuild that referenced this issue Dec 18, 2019
@Yannic
Create proto_toolchain and expose values of command-line flags on it
7e83a5b 
Working towards bazelbuild/bazel#10005
@Yannic Yannic mentioned this issue Mar 29, 2020
Closed
@cheister cheister mentioned this issue Apr 3, 2020
Open
@Yannic Yannic mentioned this issue Aug 17, 2020
Closed
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
ed2ad15 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
ed9833c 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
@Yannic Yannic mentioned this issue Nov 14, 2020
Closed
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
da4e3e3 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
81fa72c 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
36aad53 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Create proto_toolchain rule
9e87fa2 
This change adds a new `proto_toolchain` rule which we will use later to resolve
tools and options required to compile Protocol Buffers, thus eventually replacing
some of the command-line options from `ProtoConfiguration`.

To preclude inconsistencies in the migration period, we will start with a
`proto_toolchain` rule that doesn't have any arguments and populate
its provider from the existing command-line options. After all consumers
have been migrated to resolve the tools from the toolchain instead of
reading the command-line, we will replace all proto-specific flags with
attributes on `proto_toolchain` (or similar, language-specific toolchains
for flags that only affect a specific language).

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Accept proto_library as //tools/objc:protobuf_well_known_types
d8fb0c4 
Part of the migration of Protobuf rules/aspects to `ProtoSource`.
A future change will make `ProtoInfo` mandatory (similar to what was
done for `proto_lang_toolchain`).

Note that this is for Obj-C Protobuf rules which don't exist in Bazel.

Updates bazelbuild#10005
Yannic added a commit to Yannic/bazel that referenced this issue Nov 14, 2020
@Yannic
Accept proto_library as //tools/objc:protobuf_well_known_types
c6d0c23 
Part of the migration of Protobuf rules/aspects to `ProtoSource`.
A future change will make `ProtoInfo` mandatory (similar to what was
done for `proto_lang_toolchain`).

Note that this is for Obj-C Protobuf rules which don't exist in Bazel.

Updates bazelbuild#10005
@Yannic Yannic mentioned this issue Nov 14, 2020
Closed
@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 18, 2020
bazel-io pushed a commit that referenced this issue Nov 27, 2020
@Yannic @copybara-github
Accept proto_library as //tools/objc:protobuf_well_known_types
c85ecbe 
Part of the migration of Protobuf rules/aspects to `ProtoSource`.
A future change will make `ProtoInfo` mandatory (similar to what was
done for `proto_lang_toolchain`).

Note that this is for Obj-C Protobuf rules which don't exist in Bazel.

Updates #10005

Closes #12486.

PiperOrigin-RevId: 344498042
Yannic added a commit to Yannic/bazel that referenced this issue Jan 26, 2021
@Yannic
ProtoConfiguration: Expose some fields to Starlark
af11d09 
This change exposes the values of `--protoc` and `--proto_options` to
Starlark, thus making it possible to implement `proto_toolchain` in
Starlark. See bazelbuild/rules_proto#82 for the
implementation of `proto_toolchain`.

Working towards bazelbuild#10005
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yannic Yannic

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Server Issues for serverside rules included with Bazel type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jin @hlopko @lberki @Yannic @sgowroji