Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish completion suggested completions have double parentheses #12209

Closed
uri-canva opened this issue Oct 2, 2020 · 1 comment
Closed

Fish completion suggested completions have double parentheses #12209

uri-canva opened this issue Oct 2, 2020 · 1 comment
Labels
help wanted Someone outside the Bazel team could own this team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Comments

@uri-canva
Copy link
Contributor

Description of the problem / feature request:

When completing an option:

> bazel info --
----auto_output_filter                                                                                                                        ((none, all, packages or subpackages; default: "none"))
----bes_backend                                                                                                                                                             ((a string; default: ""))
----bes_keywords                                                                                                                      ((comma-separated list of options; may be used multiple times))
----bes_outerr_buffer_size                                                                                                                                           ((an integer; default: "10240"))
----bes_outerr_chunk_size                                                                                                                                          ((an integer; default: "1048576"))

Note how the description of the options are wrapped in two sets of parentheses like ((none, all, packages or subpackages; default: "none")).

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Source fish completions, try to autocomplete bazel info --.

What operating system are you running Bazel on?

sw_vers
ProductName: Mac OS X
ProductVersion: 10.15.7
BuildVersion: 19H2

fish --version
fish, version 3.1.2

What's the output of bazel info release?

release 3.3.0

Have you found anything relevant by searching the web?

Issue requesting fish completions: #5088
Initial implementation: https://github.com/bazelbuild/bazel/pull/11450/files

@uri-canva
Copy link
Contributor Author

cc @tmandry @akirabaruah

@meisterT meisterT added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website help wanted Someone outside the Bazel team could own this labels Oct 2, 2020
akirabaruah added a commit to akirabaruah/bazel that referenced this issue Oct 13, 2020
Fish shell completion for bazel previously relied on parsing bazel help
text at run time, leading to latency of multiple seconds for first-time
completion. This change adds a script that instead parses bazel help
text and generates an appropriate fish completion script at build time,
greatly reducing completion latency for the user.

Fixes bazelbuild#12206
Fixes bazelbuild#12207
Fixes bazelbuild#12208
Fixes bazelbuild#12209
Fixes bazelbuild#12210
akirabaruah added a commit to akirabaruah/bazel that referenced this issue Oct 14, 2020
Fish shell completion for bazel previously relied on parsing bazel help
text at run time, leading to latency of multiple seconds for first-time
completion. This change adds a script that instead parses bazel help
text and generates an appropriate fish completion script at build time,
greatly reducing completion latency for the user.

Fixes bazelbuild#12206
Fixes bazelbuild#12207
Fixes bazelbuild#12208
Fixes bazelbuild#12209
Fixes bazelbuild#12210
akirabaruah added a commit to akirabaruah/bazel that referenced this issue Oct 15, 2020
Fish shell completion for bazel previously relied on parsing bazel help
text at run time, leading to latency of multiple seconds for first-time
completion. This change adds a script that instead parses bazel help
text and generates an appropriate fish completion script at build time,
greatly reducing completion latency for the user.

Fixes bazelbuild#12206
Fixes bazelbuild#12207
Fixes bazelbuild#12208
Fixes bazelbuild#12209
Fixes bazelbuild#12210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants